-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Style guide): Modified the preview callout title #17826
Conversation
Hi @nbaenam 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nbaenam All of the callout titles should be uppercased, so <Callout title="preview">
should be <Callout title="Preview">
@nbaenam I'm working with the legal team to clarify our callout message. Let's not publish this until we get clarity on this from them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nbaenam I think we're supposed to add this legal language into each existing preview callout.
src/content/docs/alerts/incident-management/postmortems-applied-intelligence.mdx
Show resolved
Hide resolved
...ntent/docs/infrastructure/host-integrations/host-integrations-list/atlassian-integration.mdx
Show resolved
Hide resolved
...ocs/infrastructure/host-integrations/host-integrations-list/ibmmq-monitoring-integration.mdx
Show resolved
Hide resolved
.../infrastructure/host-integrations/host-integrations-list/powerdns-monitoring-integration.mdx
Show resolved
Hide resolved
...content/docs/kubernetes-pixie/kubernetes-integration/installation/kubernetes-eks-fargate.mdx
Show resolved
Hide resolved
src/content/docs/kubernetes-pixie/kubernetes-integration/installation/kubernetes-windows.mdx
Show resolved
Hide resolved
src/content/docs/nrql/using-nrql/query-infrastructure-dimensional-metrics-nrql.mdx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nbaenam sorry to slow this down, but I found two more items to consider. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nbaenam thanks for adding these changes! This looks good to me!
Updated the callout preview in the style guide and throughout the docs site.